-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve food import from JSON #529
Conversation
Does this include searching using the text search, rather than barcode? Does the search work if the user is offline? |
It refers exclusively to the local text search. Scanning a barcode or doing an online search (by hitting Enter) won't find these imported items.
Yes. |
So if I type "a" all the hidden foods containing the letter "a" will appear in the list? |
Yes. If this is a problem, I could change it so these items only appear if you also apply a category filter. But then we would need to ensure during the import that the user selected at least one category to be applied to the items (because otherwise they could never be found). |
I'm thinking it might be a little confusing because, when you don't press enter, the search box acts as a filter for the list of items you can see and when you press enter it searches for items you can't see. So revealing hidden items when filtering might be unexpected. But I think we should try it for now and see how it works in the real world. |
I agree. I have now changed it so the hidden items only show up when the category search filter is applied. This makes for a much better user experience. |
This improves the food import feature added in #528.
Imported items are now hidden unless the user
explicitly searches for them oruses the category filter. This makes it possible to integrate all kinds of external databases without polluting the food list with unused entries, so we can close #388 and also close #230.